Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dwd examples #144

Merged
merged 8 commits into from
Jan 22, 2024
Merged

Dwd examples #144

merged 8 commits into from
Jan 22, 2024

Conversation

antje-s
Copy link
Contributor

@antje-s antje-s commented Dec 1, 2023

We have updated our examples and created a new one for observations from Germany with a link to Oscar.
We noticed the following when updating our examples:

  • time-Section:

    • interval does not accept durations
    • interval does not accept multiple arrays
    • time: null is not accepted
  • WTH themes/concept

    • metadata without any block for "scheme": "https://github.com/wmo-im/wis2-topic-hierarchy/..." are valid and even grade "A"
    • metadata should include the most specific csv as scheme-link (inside domain-specific)
    • centre-id.csv should always be included in concepts
    • we need a service to create a full WTH value out of metadata record
  • additionalExtents.temporal

    • does not accept more than one block (example icon-eps different resolutions for different forecast ranges)
  • ets validation

    • response for not valid JSON as response/result included?

@antje-s
Copy link
Contributor Author

antje-s commented Dec 1, 2023

additional remark:

  • some parts of docs are not adjusted for latest updates, e.g. examples

@tomkralidis
Copy link
Collaborator

TT-WISMD 2024-01-15: @tomkralidis to review against pywcmp and current OARec/WCMP2 schema

@tomkralidis tomkralidis reopened this Jan 18, 2024
@tomkralidis tomkralidis merged commit 111678f into main Jan 22, 2024
4 checks passed
@tomkralidis tomkralidis deleted the dwd_examples branch January 22, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants